Add auto detection of Language #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Remeic we will do some old style tests ASAP. ;) thank you very much for your contribution; feel free to choose another issue if you want to. Bye, Alberto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue related to #9
Add auto detection of language using navigator.language, i create an object with key and value.
Keys are the values can be returned by navigator.languages ( list here ) and values are our label for i18n translation files.
Navigator language is set to lowercase for support also safari < 10.2 (here)
I wanted to add test too, but test suite pass every time, even if i try to write test that fail.
I hope my contribution can be useful